Added support for pulling the owners profile photo from the addressbook.#4
Open
touchbee wants to merge 2 commits intojakeboxer:masterfrom
touchbee:master
Open
Added support for pulling the owners profile photo from the addressbook.#4touchbee wants to merge 2 commits intojakeboxer:masterfrom touchbee:master
touchbee wants to merge 2 commits intojakeboxer:masterfrom
touchbee:master
Conversation
Owner
|
Hey @touchbee, This looks pretty good. A few quick changes that would be great before I merge this:
|
Author
|
Hi Jake,
|
Removed image retrieval for iOS < 4.2. Reformatted code.
Owner
|
@touchbee yep, 2 spaces. Also, keep an eye on other little things. For example, I don't do spaces inside parentheses or a blank line after every line of code. |
|
Hi @touchbee @jakeboxer, I'd love to see this PR get merged in for a project I'm working on! Could you take another look? |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.